Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a RemMixed trait and impl for Uints #746

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Jan 20, 2025

Add a RemMixed trait in the same vein as SplitMixed and ConcatMixed, to calculate the remainder of differently sized integers.

Fixes #739.

@tarcieri
Copy link
Member

This looks fine as a general direction

@dvdplm
Copy link
Contributor Author

dvdplm commented Jan 20, 2025

What else would you like to see done here, can you give me a rough idea?

@tarcieri
Copy link
Member

@dvdplm if you think it's ready, can you remove draft?

@dvdplm dvdplm marked this pull request as ready for review January 21, 2025 08:49
@dvdplm
Copy link
Contributor Author

dvdplm commented Jan 21, 2025

In f6caf92 I added an impl for BoxedUint but not sure if that actually makes sense.

As a rule, should all traits be impl'd for Int as well as Uint, or are you handling that on a case-by-case basis?

@tarcieri
Copy link
Member

FWIW we don't impl other *Mixed traits on Boxed* types.

Re: trait parity for Uint and Int, since the latter is something of a relatively new addition and not fully featured yet, we haven't been worrying about that, but it would probably be a good eventual goal.

@tarcieri tarcieri merged commit 0761be3 into RustCrypto:master Jan 21, 2025
18 checks passed
@tarcieri tarcieri mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access to rem_wide_vartime through a trait
2 participants