Add BoxedUint::gcd
#497
Merged
Add BoxedUint::gcd
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for computing the greatest common divisor of two `BoxedUint`s using Bernstein-Yang
tarcieri
force-pushed
the
boxed-uint/gcd
branch
from
e86a80f to
1dc7262
Compare
tarcieri
commented
Dec 23, 2023
Comment on lines
+6
to
+11
| impl Odd<BoxedUint> { | ||
| /// Compute the greatest common divisor (GCD) of this number and another. | ||
| pub fn gcd(&self, rhs: &BoxedUint) -> BoxedUint { | ||
| bernstein_yang::boxed::gcd(self, rhs) | ||
| } | ||
| } |
There was a problem hiding this comment.
Defining the method on Odd allows it to be infallible (since Bernstein-Yang requires self is odd), though perhaps there should be a more convenient way to call it and get a CtOption
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for computing the greatest common divisor of two
BoxedUints using Bernstein-Yang