Add Odd newtype
#487
Merged
Add Odd newtype
#487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjarri
reviewed
Dec 20, 2023
fjarri
reviewed
Dec 20, 2023
tarcieri
force-pushed
the
odd-newtype
branch
from
7e511d7 to
20d04bf
Compare
tarcieri
commented
Dec 20, 2023
tests/uint_proptests.rs
Outdated
Comment on lines
144
to
145
| assert!(a < P); | ||
| assert!(b < P); | ||
| assert!(a < *P); | ||
| assert!(b < *P); |
There was a problem hiding this comment.
A PartialOrd<Odd<Uint<LIMBS>> impl for Uint<LIMBS> might be handy here
tarcieri
force-pushed
the
odd-newtype
branch
2 times, most recently
from
37b0d6b to
c9bad93
Compare
|
|
Adds a newtype similar to `NonZero` which identifies odd integers at the type level. This can be used for infallible conversions for moduli, i.e. reusing a `*MontParams` modulus as a Bernstein-Yang modulus infallibly.
This makes the constructors infallible
tarcieri
force-pushed
the
odd-newtype
branch
from
5d215d9 to
57c18de
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a newtype similar to
NonZerowhich identifies odd integers at the type level.This can be used for infallible conversions for moduli, i.e. reusing a
*MontParamsmodulus as a Bernstein-Yang modulus infallibly.Closes #479