Implement Zeroize for NonZero wrapper
#406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Dec 8, 2023
@aumetra how's that going? |
Pretty good actually. Looking at the code, it should only leak public factors through the few vartime operations needed. The only thing I'm waiting for right now is |
|
@aumetra FYI, new |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to port over
dsatocrypto-bigint, I noticed that theNonZerowrapper has no implementation for theZeroizetrait.That made it a bit annoying to implement the internals that expect the private factor
xto be wrapped into aZeroizingwrapper.