New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Div-by-2 adjustment #212

Merged

tarcieri merged 2 commits into RustCrypto:master from fjarri:div-by-2-p2

Apr 20, 2023

Contributor

fjarri commented Apr 20, 2023

A minor improvement I missed in the original PR.

use shr_1() instead of calling is_odd() separately
update the docstring of shr_1() to reflect that it now returns a CtChoice

fjarri added 2 commits

April 20, 2023 13:32


          Use shr_1() to calculate the shifted value and parity at the same time

07b1db4


          Update the docstring of shr_1()

6fc4f09

tarcieri approved these changes

View reviewed changes

tarcieri merged commit 2a29f9a into RustCrypto:master

fjarri deleted the div-by-2-p2 branch

April 21, 2023 17:17

tarcieri mentioned this pull request

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet