Rename BIT_SIZE
-> BITS
, BYTE_SIZE
-> BYTES
#157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154
BIT_SIZE
toBITS
andBYTE_SIZE
toBYTES
to match the constants in the primitive typesBITS
andBYTES
toUint
(instead of only having them inEncoding
), similarly to how it's done forLimb
Now about the
usize
->u32
, I've tried to implement that, and I am reconsidering it. It really feels more natural in many places to have those constants beusize
, otherwise there's a lot ofas
casts necessary (unless we also haveconst LIMBS: u32
).leading_zeros()
etc can be made to returnu32
more easily, but that would introduce an inconsistency withBITS
. Perhaps we can leave the types as is after all.