Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixslice64.rs got clobbered? #246

Closed
peterdettman opened this issue May 9, 2021 · 2 comments · Fixed by #247
Closed

fixslice64.rs got clobbered? #246

peterdettman opened this issue May 9, 2021 · 2 comments · Fixed by #247

Comments

@peterdettman
Copy link
Contributor

aes/src/soft/fixslice64.rs appears to have been copied over with the contents of aes/src/soft/fixslice32.rs in commit 61cd5de.
@tarcieri
Copy link
Member

tarcieri commented May 9, 2021

Oh wow, that's bad.

Would you like to take care of fixing it or should I?

@peterdettman
Copy link
Contributor Author

Please take care of it; I'd need to refresh my setup.

tarcieri added a commit that referenced this issue May 9, 2021
@tarcieri
aes: restore fixslice64.rs
733b462 
It appears that `fixslice64.rs` was accidentally overwritten with
`fixslice32.rs` in #208.

This restores the 64-bit implementation to what it was prior to that PR.

Closes #246.
@tarcieri tarcieri mentioned this issue May 9, 2021
Merged
tarcieri added a commit that referenced this issue May 9, 2021
@tarcieri
aes: restore fixslice64.rs (#247)
0fd47e3 
It appears that `fixslice64.rs` was accidentally overwritten with
`fixslice32.rs` in #208.

This restores the 64-bit implementation to what it was prior to that PR.

Closes #246.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

aes: restore fixslice64.rs RustCrypto/block-ciphers
2 participants
@tarcieri @peterdettman