ssh-key: fix parsing comments with whitespace in AuthorizedKeys
#289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssh_key::PublicKey::read_openssh_file
can read the following key:However, if I treat it as a single-line
authorized_keys
and read it withssh_key::AuthorizedKeys::read_file
, it fails:This is because the
authorized_keys
parser doesn't respect spaces in the comment field, so it's trying to parseecdsa-sha2-nistp256
as the options andhello
as the key material.This PR fixes the issue, and also adds a unit test for
authorized_keys
with whitespace in their comments.