ssh-encoding: remove NestedReader
#226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
ssh-encoding/remove-nested-reader
branch
4 times, most recently
from
1c6cdd4
to
e4ba8fc
Compare
Changes `Reader::read_prefixed` from a provided method to one which must be impl'd by all of the `Reader` types, of which there are currently three: - `&[u8]` - `Base64Reader` - `PemReader` This should reduce monomorphization bloat from `NestedReader` which encapsulates other reader types, including other `NestedReader`s, depending on the level of nesting, which is generally low, but good to eliminate entirely. The `Reader` impl is written identically between `Base64Reader` and `PemReader` and currently impl'd as a macro to prevent duplication, however a more elegant solution would be nice, e.g. a generic method.
tarcieri
force-pushed
the
ssh-encoding/remove-nested-reader
branch
from
e4ba8fc
to
ec120f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reader::read_prefixedfrom a provided method to one which must be impl'd by all of theReadertypes, of which there are currently three:&[u8]Base64ReaderPemReaderThis should reduce monomorphization bloat from
NestedReaderwhich encapsulates other reader types, including otherNestedReaders, depending on the level of nesting, which is generally low, but good to eliminate entirely.This does lead to a small amount of duplication between
Base64ReaderandPemReaderwhich was previously encapsulated inNestedReader. It can possibly be eliminated in followup work.