ssh-key: have PublicKey and its parts implment Hash #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nresare
force-pushed
the
implement_Hash
branch
3 times, most recently
from
3c16d43
to
2b50241
Compare
tarcieri
reviewed
Aug 6, 2023
tarcieri
reviewed
Aug 6, 2023
This change derives the Hash trait for PublicKey and it's constitutent parts. Since Mpint implements its own PartialEq, an explicit Hash implmenetation delegating to the backing byte vector is added. A test verifying that a HashSet containing a public key can indeed be created and queried is also added.
|
I'll probably do another pass over this before release, but the general idea can be supported |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the Hash trait enables using PublicKeys and relatives as HashMap keys and in HashSets.