This repository has been archived by the owner on Jul 27, 2021. It is now read-only.
[Breaking Change] Abstract Instrument type into its own crate and use it as a dependency. Replace rustc-serialize with serde_serialization feature. Move dsp-chain behind feature.
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After RustAudio/envelope#19 |
|
Are you going through with this PR or is it obsolete in some way? |
|
@filmor thanks for the reminder, I'm a bit busy atm but I'll resolve the conflict and merge this asap 👍 |
|
How is this going so far? |
|
Has this PR been abandoned? |
Updated to latest changes to the envelope crate API. Primarily, this was moving Envelope type params to associated types in the trait implementation. Added a Frames iterator for rendering audio data one Frame at a time, using the newly upgraded sample crate. Moved dsp-chain Node implementation into its own dsp_node module behind a feature gate (which is on by default). Removed all rustc-serialize attributes in favour of manually implemented serde trait implementations behind a serde_serialization feature gate in a unique serde.rs module. Removed special dynamic::Synth type in favour of doing a unique impl for dynamic::Synth type alias. Allows for removing many tuple accessor fields from downstream crates. Added many missing PartialEq implementations, mostly to allow for easy serialization testing in the serde.rs module.
…dded instrument crate to toml, updated other crates in toml, removed rustc-serialize from toml).
…time_calc and dsp-chain crate versions. Remove rustc-serialize.
…dd test for dynamic::Synth serialization.
mitchmindtree
force-pushed
the
abstract_instrument
branch
from
13c6c35 to
6b32065
Compare
|
Sorry about the wait folks! Published as 0.11.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.