Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bindgen build dependency to 0.51 #30

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Update bindgen build dependency to 0.51 #30

merged 1 commit into from
Sep 23, 2019

Conversation

glandium
Copy link
Contributor

No description provided.

@repi
Copy link

repi commented Sep 23, 2019

We've had a fork that does this too, would be great to merge this into master and publish a new release with it

est31
est31 approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@est31 est31 merged commit 451dea5 into RustAudio:master Sep 23, 2019
@est31
Copy link
Member

est31 commented Sep 23, 2019

I've merged this and will do a 0.2.3 release at the end of the week (unless @mitchmindtree beats me to it).

@est31
Copy link
Member

est31 commented Sep 28, 2019

Any idea why CI is failing on master?

@glandium
Copy link
Contributor Author

See 7a51ced

I guess changes in rustfmt 0.51might have broken CI finding the rustfmt executable.

@est31
Copy link
Member

est31 commented Sep 28, 2019

The job exceeded the maximum log length, and has been terminated.

Hmm yeah that might be the issue: rust-lang/rust-bindgen#1600

I'll add a local workaround for this repo until the upstream bug is resolved.

@est31
Copy link
Member

est31 commented Sep 28, 2019

I guess we'll need this commit or set rustfmt in another way. I've filed #31 for experimentation.

@est31 est31 mentioned this pull request Sep 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@est31 est31 est31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glandium @repi @est31