Skip to content

Commit

Permalink
Alex's review
Browse files Browse the repository at this point in the history
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
  • Loading branch information
ojeda committed Sep 5, 2020
1 parent 40cbc3f commit 351ab09
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Documentation/rust/quick-start.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This document describes how to get started with Rust kernel development.
Requirements
------------

A nightly Rust toolchain (at least ``rustc``, ``cargo`` and ``rustfmt``) is required. In the future, this restriction will be lifted. If you are using ``rustup``, run::
A recent nightly Rust toolchain (at least ``rustc``, ``cargo`` and ``rustfmt``) is required, e.g. `nightly-2020-08-27`. In the future, this restriction will be lifted. If you are using ``rustup``, run::

rustup toolchain install nightly

Expand Down
2 changes: 2 additions & 0 deletions rust/kernel/src/filesystem.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// SPDX-License-Identifier: GPL-2.0

// TODO: `filesystem` is really incomplete -- deletion to be considered

use alloc::boxed::Box;
use core::default::Default;
use core::marker;
Expand Down
2 changes: 2 additions & 0 deletions rust/kernel/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ macro_rules! kernel_module {
($module:ty, $($name:ident : $value:expr),*) => {
static mut __MOD: Option<$module> = None;

// Built-in modules are initialized through an initcall pointer
//
// TODO: find a proper way to emulate the C macro, including
// dealing with `HAVE_ARCH_PREL32_RELOCATIONS`
#[cfg(not(module))]
Expand Down

0 comments on commit 351ab09

Please sign in to comment.