Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] In-Browser File Editor for Volume Browser #1441

Merged
merged 5 commits into from
Feb 15, 2025
Merged

[ADD] In-Browser File Editor for Volume Browser #1441

merged 5 commits into from
Feb 15, 2025

Conversation

XK4MiLX
Copy link
Member

@XK4MiLX XK4MiLX commented Feb 14, 2025 •
edited
Loading

In-Browser File Editor

Key Points:

  • Integrated Editor: Uses Monaco Editor for in-browser file editing.
  • Syntax Highlighting: Supports multiple languages with dynamic auto-detection (using highlight.js).
  • Responsive Modal: Embedded in a responsive modal with fixed dimensions for proper layout and internal scrolling.
  • Automatic Layout: Adjusts automatically to container size changes.
  • Support dark and light mode

Limitations:

  • File Size Limit: Designed for files up to 3MB; larger files will trigger a warning advising the use of a terminal-based editor.
  • Auto-Detection Accuracy: Language auto-detection may not be perfect for all file types.

@XK4MiLX
[ADD] File editor for volume browser
fa4a10d
@XK4MiLX
[ADD] Dependencies for file editor
82a4bde
@XK4MiLX
Style correction
0261843 
- Hide default header close button using hide-header-close
- Create custom modal header slot to position the close button inside the header
- Adjust header text styling for improved readability with the theme
- Update CSS to set a transparent backdrop on the modal for a subtle overlay effect
@XK4MiLX
Update extensionMapping
df50db5
@XK4MiLX
[FIX] FileType selection and style improvements
04c1775 
- Correct fileType selection logic for accurate file assignment
- Refine UI styling for enhanced visual consistency and readability
Cabecinha84
Cabecinha84 approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@Cabecinha84 Cabecinha84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@Cabecinha84 Cabecinha84 merged commit 91a8d8a into development Feb 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cabecinha84 Cabecinha84 Cabecinha84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XK4MiLX @Cabecinha84