-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arihan/mar 8 ability to comment by line of code in pr #55
Changes from 1 commit
48df5f7
88e74d3
80ce114
5088ffa
5b1cef8
49d3193
c01b888
5f0696c
5ddc312
3f8b119
72074e9
0da48d1
484e2f9
f9092cc
4a651be
707aac3
eea274f
fba6cfc
54179b8
4e34447
836883e
2b5384e
9b6b922
cd7d978
482f313
6666976
a009c12
7eec620
d291152
d909615
a1016db
8a86bad
a20406d
be974c6
b1626ed
a05c2b6
3bd0960
78ad53a
16729c8
101df88
b27846f
f429951
57bbc1e
10dde12
b6e26e2
6e8691e
54dbda1
169e35d
9aaf357
2b592dd
058459e
949214a
086083a
9887f0e
2462800
8b5dde6
4160457
a9534f0
c2e2a2e
0c4b925
2f9e7f2
73b29f5
61631e0
129f403
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
import {OctokitReqType} from '@octokit/app' | ||
import {initializeAgentExecutorWithOptions} from 'langchain/agents' | ||
import {ChatOpenAI} from 'langchain/chat_models/openai' | ||
import {SerpAPI} from 'langchain/tools' | ||
|
@@ -25,7 +24,7 @@ export default async function reviewer({ | |
head | ||
}: { | ||
input: string | ||
octokit: OctokitReqType | ||
octokit: any | ||
pullId?: string | ||
owner?: string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The By Maige. How's my driving? |
||
repo?: string | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
owner
,repo
, andpull_number
parameters should be marked as required if they are necessary for thecodeComment
function to work. If they are optional, there should be a fallback or error handling mechanism in place.By Maige. How's my driving?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good point (I think) @arihanv. Wdyt?