Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build on ancient glibc without openat(AT_FDCWD #707

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix build on ancient glibc without openat(AT_FDCWD #707

merged 1 commit into from
Jan 15, 2025

Conversation

ncopa
Copy link
Contributor

@ncopa ncopa commented Jan 15, 2025

Fixes: #701

@ncopa ncopa mentioned this pull request Jan 15, 2025
Closed
@solardiz
Copy link

Separately, maybe we could add something like:

#ifdef __GNUC__
#warning "System features required for security missing, CVE-... CVE-... remain unfixed"
#endif

At least this would be triggered if AT_FDCWD ever stops being a macro (hopefully, never).

@tridge tridge merged commit 68e9add into RsyncProject:master Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solardiz solardiz solardiz approved these changes

@tridge tridge tridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.4.0 portability regression because of openat(AT_FDCWD
3 participants
@ncopa @solardiz @tridge