Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features flags for each image format #41

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

ShadowMitia
Copy link
Contributor

This PR adds features flags as mentioned in #30.

@Roughsketch
Copy link
Owner

Thank you very much for taking the time to do this! It might be a day or so before I can review it properly, but I'll try to do it sooner rather than later.

@Roughsketch
Copy link
Owner

Not sure the best way to go about larger review changes so I made a PR into your branch: ShadowMitia#1

* Feature gate tests

* Fix issues when heif is not enabled

* Allow dead code because certain feature flags will trigger it

* Revert "Fix issues when heif is not enabled"

This reverts commit d190cae.
@Roughsketch Roughsketch self-requested a review November 19, 2024 00:35
Copy link
Owner

@Roughsketch Roughsketch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Roughsketch Roughsketch merged commit 51383ac into Roughsketch:master Nov 19, 2024
1 check passed
@ShadowMitia
Copy link
Contributor Author

Pleasure!

@ShadowMitia ShadowMitia deleted the add-feature-flag-formats branch November 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants