Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PNM #29

Merged
merged 5 commits into from
May 11, 2023
Merged

Add support for PNM #29

merged 5 commits into from
May 11, 2023

Conversation

Roughsketch
Copy link
Owner

@Roughsketch Roughsketch commented May 8, 2023

This is still a work in progress. Most of it works, but there is a case in a P6 file where there are no newlines which breaks the parsing since I wrote it assuming that things would always be broken by newlines.

I do have open questions for this for anyone who cares (@akonneker?)

  • Should the ImageType be:
    • Pnm
    • Pnm(subtype)
    • Split them into Pbm, Pgm, Ppm
    • Something else?
  • Should I handle more than P1 - P6, and if so do you have example files? I've seen P7, PF, PF4, and there are probably more I'm not aware of.

Resolves #14

@Roughsketch
Copy link
Owner Author

Going to merge this as-is since it passes all the tests for the files I have now.

I have chosen to keep Pnm as its own value but I am still open to changing it later down the road if needed.

@Roughsketch Roughsketch merged commit 1751e64 into master May 11, 2023
@Roughsketch Roughsketch deleted the pnm branch May 11, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for PBM/PGM/PPM
1 participant