Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HDR files orientations #26

Merged
merged 4 commits into from
May 7, 2023
Merged

Handle HDR files orientations #26

merged 4 commits into from
May 7, 2023

Conversation

Roughsketch
Copy link
Owner

@Roughsketch Roughsketch commented May 6, 2023

While trying to figure out a better way to support HDR without relying on read_line, I came across the HDR spec. In the Resolution String section (page 31) I found out that -Y does not just denote the start of a standard width/height resolution. Resolutions can either start with +/- X/Y, which means the original implementation only supports 2/8 valid HDR resolution strings.

Before release I plan on adding support for these orientations. Not sure where I can find HDR test files for this though.

Supported orientations based on ExifTool notation:

  • Horizontal (normal)
  • Mirror horizontal
  • Rotate 180
  • Mirror vertical
  • Mirror horizontal and rotate 270 CW
  • Rotate 90 CW
  • Mirror horizontal and rotate 90 CW
  • Rotate 270 CW

@Roughsketch
Copy link
Owner Author

I believe this is finished, but going to re-run fuzzer and then see if there's anything else to tidy up. Still no test files for these cases but I think these types of images are harder to come by in specific formats and I don't know how to make them myself.

@Roughsketch Roughsketch merged commit 268b68e into master May 7, 2023
@Roughsketch Roughsketch deleted the support/hdr-rotations branch May 7, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant