Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 178 subscriber buffer size #179

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Fix 178 subscriber buffer size #179

merged 2 commits into from
Jul 30, 2024

Conversation

Carter12s
Copy link
Collaborator

@Carter12s Carter12s commented Jul 30, 2024 •
edited
Loading

Description

  • Fixed bug where subscribers weren't handling message size correctly
  • Standardized logic for receiving a ROS1 message body that was duplicated in subscriber, service_client and service_server
  • Added a unit test for subscribers for large payload

Fixes

Closes: #178

Checklist

  • Update CHANGELOG.md

@Carter12s Carter12s merged commit 952cba7 into master Jul 30, 2024
5 checks passed
@lucasw lucasw mentioned this pull request Jul 31, 2024
Open
@Carter12s Carter12s deleted the fix-178-subscriber-buffer-size branch August 3, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PointCloud2 messages exceeding serde_rosmsg buffer size
1 participant
@Carter12s