Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example for build.rs usage #135

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Add an example for build.rs usage #135

merged 1 commit into from
Oct 3, 2023

Conversation

Carter12s
Copy link
Collaborator

@Carter12s Carter12s commented Sep 30, 2023 •
edited
Loading

Closes: #120

Would not call this example "good" at this time.

Three big TODOs left:

  1. Needs the list of directories for cargo to watch to be fed back by codegen stuff
  2. Need to incorporate the error handling from the other MR
  3. Would love to fix the leaky dependencies (not sure if we actually can in this case?)

Probably good enough to merge as is and fix those with later issues.

@Carter12s Carter12s requested a review from ssnover September 30, 2023 21:01
@Carter12s Carter12s self-assigned this Sep 30, 2023
ssnover
ssnover approved these changes Oct 3, 2023
View reviewed changes
example_package/Cargo.toml Show resolved Hide resolved
@Carter12s Carter12s merged commit 23e5bc0 into master Oct 3, 2023
@Carter12s Carter12s deleted the build-rs-example branch October 5, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssnover ssnover ssnover approved these changes

Assignees

@Carter12s Carter12s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve build.rs ergonomics
2 participants
@Carter12s @ssnover