Add timeouts to ros1 tests #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d added more timeout checking to a lot of places so CI jobs don't hange for 20 minutes
|
Note: I suspect after these timeouts are added these new ROS1 tests are still flaky and we should probably add "may fail" to them for the time being. |
ssnover
approved these changes
Oct 3, 2023
Yeah I ran into this same thing with the roslibrust client and ended up building it as a feature of the crate with timeout being configurable on the NodeHandle. Likely will want to do the same thing to the ros1 client eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #122
Also nudged some other timeouts up. Just trying to keep CI jobs from hanging for 20 minutes.
Doesn't actually solve root problem likely, but makes failure quicker / more obvious (hopefully with better logs too).