Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Sciebo downloads #117

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

nilshee
Copy link
Contributor

@nilshee nilshee commented Jun 12, 2024

solves #110

Copy link
Collaborator

@septatrix septatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I currently have no Mooble room with sciebo available so I am not really able to test this. Feedback from anyone else would be appreciated though in generall I am in favor of improving the Sciebo scraping

setup.cfg Show resolved Hide resolved
syncmymoodle/__main__.py Outdated Show resolved Hide resolved
syncmymoodle/__main__.py Outdated Show resolved Hide resolved
syncmymoodle/__main__.py Outdated Show resolved Hide resolved
Co-authored-by: Nils K <24257556+septatrix@users.noreply.github.com>
@D-VR
Copy link
Collaborator

D-VR commented Sep 23, 2024

What is the status of this? Anything left open or are we good to go?

@D-VR D-VR added the enhancement New feature or request label Sep 23, 2024
@nilshee
Copy link
Contributor Author

nilshee commented Sep 23, 2024

There are still a couple of bugs, I haven't had the time to fix.

Also, naming the folders for the Sciebo downloads needs a solution. Maybe the Section headers in Moodle as folder names (if folder-share). Currently, the trailing hash of the link is used as folder name.

@nilshee
Copy link
Contributor Author

nilshee commented Oct 10, 2024

Also, some lecturers put the same Sciebo link on multiple sites cf. Post-quantum cryptography. I'm not sure how to handle that. Are relative symlinks an option or should we drop duplicates with a warning?

Also, in the same Moodle room, there is a sciebo link for the videos folder and direct links to the videos.

Does anyone have ideas on how to solve these problems? Or will we download everything multiple times?

@septatrix
Copy link
Collaborator

For now it should be finde to do the native approach and download them multiple times. Improving it can be done in a separate PR. Automatically detecting those cases it probably a bit more annoying to get right.

@D-VR
Copy link
Collaborator

D-VR commented Oct 14, 2024

For now it should be finde to do the native approach and download them multiple times. Improving it can be done in a separate PR. Automatically detecting those cases it probably a bit more annoying to get right.

there's also issues with link finding in general, even in the current search it will try out the same link multiple times.
I had started looking into it, but didn't have the time to do anything.
So yeah duplication is fine for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants