-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Sciebo downloads #117
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I currently have no Mooble room with sciebo available so I am not really able to test this. Feedback from anyone else would be appreciated though in generall I am in favor of improving the Sciebo scraping
Co-authored-by: Nils K <24257556+septatrix@users.noreply.github.com>
What is the status of this? Anything left open or are we good to go? |
There are still a couple of bugs, I haven't had the time to fix. Also, naming the folders for the Sciebo downloads needs a solution. Maybe the Section headers in Moodle as folder names (if folder-share). Currently, the trailing hash of the link is used as folder name. |
Also, some lecturers put the same Sciebo link on multiple sites cf. Post-quantum cryptography. I'm not sure how to handle that. Are relative symlinks an option or should we drop duplicates with a warning? Also, in the same Moodle room, there is a sciebo link for the videos folder and direct links to the videos. Does anyone have ideas on how to solve these problems? Or will we download everything multiple times? |
For now it should be finde to do the native approach and download them multiple times. Improving it can be done in a separate PR. Automatically detecting those cases it probably a bit more annoying to get right. |
there's also issues with link finding in general, even in the current search it will try out the same link multiple times. |
solves #110