Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cant remove app image #11

Open
Joly0 opened this issue Jun 2, 2023 · 3 comments
Open

Cant remove app image #11

Joly0 opened this issue Jun 2, 2023 · 3 comments

Comments

@Joly0
Copy link

Joly0 commented Jun 2, 2023

I have tested this and it appears that this line

WingetIntunePackager/sources/WingetIntunePackager.ps1

Line 690 in 7ee97be

Remove-Item $Location -Recurse -Force -Confirm:$false
does not work correctly. If anapp got search previously and an image was downloaded, the image cant be removed and therefore the whole folder will persist.

This might be an issue, if you want to create a second app after the first one, as the image cant be replaced by a new app.
If running the script directly through powershell, the image cant be deleted, not even manually, without completly closing the powerhell windows that was used to execute the image.
@Joly0
Copy link
Author

Joly0 commented Jun 2, 2023

Btw, was able to solve this for me by adjusting the code

@Romanitho
Copy link
Owner

Could you share your fix for others ? Thanks :)

@Joly0
Copy link
Author

Joly0 commented Jun 2, 2023

Sure, i'll open a pr tomorrow

Joly0 added a commit to Joly0/WingetIntunePackager that referenced this issue Jun 3, 2023
@Joly0
Fixes Romanitho#11
efb4da0 
Also adjusts the webrequest to search for transparent icons instead of only icons and adds a "VersionToDetect" variable to the winget-detect script for later use
Joly0 added a commit to Joly0/WingetIntunePackager that referenced this issue Jun 3, 2023
@Joly0
Fixes Romanitho#11
636b41b 
Also adjusts the webrequest to search for transparent icons instead of only icons and adds a "VersionToDetect" variable to the winget-detect script for later use
@Romanitho Romanitho mentioned this issue Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Joly0 @Romanitho