Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPO Management, error handling, log rotation and more... #257

Merged
merged 86 commits into from
Jan 17, 2023
Merged

GPO Management, error handling, log rotation and more... #257

merged 86 commits into from
Jan 17, 2023

Conversation

KnifMelti
Copy link
Contributor

Just started...

@KnifMelti KnifMelti changed the title Gpo Management GPO Management Dec 28, 2022
@KnifMelti
Copy link
Contributor Author

This optimization if run as System I need help with to confirm it's all good, @Romanitho!

@KnifMelti
Copy link
Contributor Author

KnifMelti commented Dec 30, 2022 •
edited
Loading

Remaining:

  • $UpdatesAtTime (needs to be written during install to the registry - handled by Invoke-PostUpdateActions the next Release - HOWTO?) - [EDIT]: solved, not necessary!
  • $UpdatesAtTime to the Policies too (read from existing Task)?) - [EDIT]: solved, handle in Policies next... - [EDIT]: now done!
  • Text changes/improvements in ADMX/ADML - [EDIT]: done!
  • Global README.md - [EDIT]: now done!

image

@KnifMelti KnifMelti marked this pull request as ready for review December 30, 2022 20:46
@KnifMelti
Copy link
Contributor Author

KnifMelti commented Dec 30, 2022 •
edited
Loading

Forgot the settings:

  • InstallUserContext - [Edit]: done!
  • NoClean - [Edit]: not relevant, only used when installing/uninstalling
  • DesktopShortcut - [Edit]: done!
  • StartMenuShortcut - [Edit]: done!

But, I'll leave them for the time being; maybe in a future... - [Edit]: done!

@KnifMelti KnifMelti changed the title GPO Management GPO Management and more... Jan 8, 2023
@KnifMelti
Copy link
Contributor Author

Logrotation closes #235

@KnifMelti KnifMelti marked this pull request as draft January 13, 2023 01:54
@KnifMelti
Copy link
Contributor Author

@Romanitho Could you verify if I'm doing it correctly in Invoke-PostUpdateActions when it comes to WAU auto updates if new version is available on Github and the registry changes for -MaxLogFiles/-MaxLogSize?

@KnifMelti KnifMelti marked this pull request as ready for review January 13, 2023 02:43
@KnifMelti KnifMelti marked this pull request as draft January 13, 2023 04:30
@KnifMelti KnifMelti marked this pull request as ready for review January 13, 2023 13:07
@Romanitho
Copy link
Owner

Really thank you for this hard work. And sorry to be less present on this project at the moment. But you are a very good captain 😉 Let me know when this part is ready and I think it will be the perfect time for a new version 😁

@KnifMelti
Copy link
Contributor Author

KnifMelti commented Jan 13, 2023 •
edited
Loading

I'm using it on over 200 clients and rolling out to 5-6K when I'm done with the documentation etc.
But, It's a good idea to check every bit ones again (how many times now...) to make sure there's nothing game breaking in it!
I'll howl when I'm ready then, leaving it as ready for review.

@KnifMelti
Copy link
Contributor Author

KnifMelti commented Jan 13, 2023 •
edited
Loading

@Romanitho My work's done!

@KnifMelti
Copy link
Contributor Author

Really, I have to let it go...

@KnifMelti
Copy link
Contributor Author

@Romanitho Done, done, done... 😜

@Romanitho Romanitho merged commit dd4cc70 into Romanitho:main Jan 17, 2023
@KnifMelti KnifMelti changed the title GPO Management and more... GPO Management, error handling, log rotation and more... Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Romanitho Romanitho Romanitho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KnifMelti @Romanitho @GAJ-san