Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github pull_request_template.md to include README update, remove Task section #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −8
Open

Update Github pull_request_template.md to include README update, remove Task section #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
## Task

[TR #XXX]()

## Why?

Why were the changes needed? What issues were the changes addressing?
Expand All @@ -15,6 +11,10 @@ What changed in this PR?
* [ ] Change 2
* [ ] ...
Comment on lines 11 to 12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [ ] Change 2
* [ ] ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apply to generator template also


## Pre-merge checklist

* [ ] Update relevant READMEs

## Screenshots

If any UI changes need to be shown off, please add screenshots here.
8 changes: 4 additions & 4 deletions lib/generators/rolemodel/github/templates/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
## Task

[TR #XXX]()

## Why?

Why were the changes needed? What issues were the changes addressing?
Expand All @@ -15,6 +11,10 @@ What changed in this PR?
* [ ] Change 2
* [ ] ...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on removing these extras? I always need to delete them and add my own

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hitting Enter after a todo adds a new one automatically, so I agree these are unnecessary.

Copy link
Member

@OutlawAndy OutlawAndy Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though, I guess this is the important file to make the change in. Isn't it?

Comment on lines 11 to 12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [ ] Change 2
* [ ] ...


## Pre-merge checklist

* [ ] Update relevant READMEs

## Screenshots

If any UI changes need to be shown off, please add screenshots here.