Picopass config se problem (#90)

Co-authored-by: あく <alleteam@gmail.com>
RogueMaster · Dec 20, 2023 · d1d45d8 · d1d45d8
1 parent aa05d75
commit d1d45d8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/picopass/.catalog/changelog.md b/picopass/.catalog/changelog.md
@@ -2,6 +2,8 @@
  - Update working with keys with new API
  - Display more tag information
  - Add additional keys to elite dict
+ - Correct config card detection so it doesn't happen for SE cards (read using nr-mac partial read)
+ - Have back button go to start menu instead of read retry
 ## 1.10
  - Fix missing folder in readme
  - Allow partial save for any read failure

diff --git a/picopass/scenes/picopass_scene_read_card_success.c b/picopass/scenes/picopass_scene_read_card_success.c
@@ -52,7 +52,6 @@ void picopass_scene_read_card_success_on_enter(void* context) {
 
         if(pacs->se_enabled) {
             furi_string_cat_printf(credential_str, "SE enabled");
-
         } else if(!hid_csn) {
             furi_string_cat_printf(credential_str, "Non-HID CSN");
         }
@@ -69,6 +68,15 @@ void picopass_scene_read_card_success_on_enter(void* context) {
             "More",
             picopass_scene_read_card_success_widget_callback,
             picopass);
+    } else if(pacs->se_enabled) {
+        furi_string_cat_printf(credential_str, "SE enabled");
+        furi_string_cat_printf(wiegand_str, "SIO");
+        widget_add_button_element(
+            widget,
+            GuiButtonTypeRight,
+            "More",
+            picopass_scene_read_card_success_widget_callback,
+            picopass);
     } else if(configCard) {
         furi_string_cat_printf(wiegand_str, "Config Card");
     } else if(empty) {
@@ -86,9 +94,6 @@ void picopass_scene_read_card_success_on_enter(void* context) {
         } else {
             furi_string_cat_printf(wiegand_str, "Invalid PACS");
         }
-        if(pacs->se_enabled) {
-            furi_string_cat_printf(credential_str, "SE enabled");
-        }
         widget_add_button_element(
             widget,
             GuiButtonTypeCenter,
@@ -190,6 +195,10 @@ bool picopass_scene_read_card_success_on_event(void* context, SceneManagerEvent
             consumed = scene_manager_search_and_switch_to_another_scene(
                 picopass->scene_manager, PicopassSceneStart);
         }
+    } else if(event.type == SceneManagerEventTypeBack) {
+        scene_manager_search_and_switch_to_previous_scene(
+            picopass->scene_manager, PicopassSceneStart);
+        consumed = true;
     }
     return consumed;
 }