[FIX] error in conformer model #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conformer model expected properties of transition group that were not present. Require a spectral library to get the library intensities
update pad/slicing interface for chromatograms that are smaller than window to be the window size
automatically set window size based on the supplied model
singjc
requested changes
Jan 24, 2024
| @@ -73,8 +76,9 @@ def load_model(self): | |||
| raise ImportError("onnxruntime is required for loading the pretrained Conformer model, but not installed.") | |||
| # Load pretrained model | |||
| self.onnx_session = onnxruntime.InferenceSession(self.pretrained_model_file) | |||
| self.window_size = self.onnx_session.get_inputs()[0].shape[2] | |||
There was a problem hiding this comment.
Can you wrap this in an exception handling to assert that get_inputs() must have a value (non-empty list) and that the first input must be a 3 dimensional array.
rename pad to adjust_length because the length can either be padded or truncated
singjc
approved these changes
Jan 24, 2024
massdash/structs/Spectrum.py
Outdated
| def adjust_length(self, length: int) -> 'Spectrum': | ||
| """ | ||
| Adjust the length of the mobilogram to a given length, this involved either padding or truncating the chromatogram |
There was a problem hiding this comment.
mobilogram/chromatogram -> spectrum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conformer model expected properties of transition group that were not present. Change UI such that require a spectral library to get the library intensities.
TODO: Fix breaking changes to the UI side
Contents (#72)
Other
Uncategorised!