Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/test consolidation #107

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Fix/test consolidation #107

merged 2 commits into from
Jan 26, 2024

Conversation

irahorecka
Copy link
Collaborator

@irahorecka irahorecka commented Jan 25, 2024

Description

Move testFileGeneration/ in the project root directory to test/ and update directory name to _test_data_generation/.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Test

Checklist:

  • My code follows the style guidelines of this project

Contents (#107)

Uncategorised!

  • move test file generation folder within test/
  • update docstring header

Copy link
Collaborator

@singjc singjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I think we need to add a bit more unit tests for certain class/modules. Would you be able to peruse the code base and add some tests for major things that you think would be important for testing? Which can be done in a separate PR. This one can be merged.

@singjc singjc merged commit b157bd3 into dev Jan 26, 2024
10 checks passed
@singjc singjc deleted the fix/test_consolidation branch January 26, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants