Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Adds prometheus data, Spaceport America 2022 #601

Merged
merged 7 commits into from
May 30, 2024

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented May 16, 2024

Pull request type

  • ReadMe, Docs and GitHub updates

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

New behavior

A new flight has been added to our "Flight Examples" page!

Breaking change

  • No

Additional information

Many thanks to Giorgio Chassikos and the Western Engineering Rocketry Team

@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner May 16, 2024 08:41
@Gui-FernandesBR Gui-FernandesBR added the Docs Docs and examples related label May 16, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone May 16, 2024
Copy link
Member

@MateusStano MateusStano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rocket is from Spaceport 2022, but the environment on the notebook is using 2023 data. Is this correct?

Also, something is wrong here:

image

@Gui-FernandesBR
Copy link
Member Author

The rocket is from Spaceport 2022, but the environment on the notebook is using 2023 data. Is this correct?

Also, something is wrong here:

image

I was running late and wanted publish it as fast as possible, so I used the environment of 2023, which was already saved in our repo, rather than download the 2022 data from Copernicus.

Do you think it's so important to update with the 2022 environment data?

Regarding the acceleration, this is interesting, right?
Seems like the telemetry data is presenting the acceleration as the derivative of speed. After burnout, the rocket constantly reduces its speed, and the telemetry plot represents it.

RocketPy's acceleration will always be in absolute value, no matter if the rocket is speeding up or down. Probably because the acceleration is calculated as the sqrt of ax2 + ay2 + az**2

If you want the plots to match perfectly, we could apply the abs() function to the telemetry data. Is this important?

I see this as a beautiful thing.

@chasgior214
Copy link

Just in case you hadn't seen it yet, the dataset I sent @Gui-FernandesBR from our other flight computer (the TeleMetrum) had a full set of speed data (unlike the TeleMega data). It could be used for a speed comparison to RocketPy. The data from that flight computer is also a lot smoother than the data from the TeleMega.

Base automatically changed from bug/plot-drag-curves-callable-function-source to develop May 16, 2024 23:41
@Gui-FernandesBR
Copy link
Member Author

I swapped the telemetry files and applied a normalization in the data. This is the final plot:

image

@Gui-FernandesBR
Copy link
Member Author

@MateusStano ready for review please

@Gui-FernandesBR Gui-FernandesBR merged commit 597cd22 into develop May 30, 2024
2 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the doc/adds-prometheus-data branch May 30, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Docs and examples related
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants