FIX: cp_position call in rocket.draw to work with mach dependent cp_position #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Gui-FernandesBR,
MateusStano and
phmbressan
Gui-FernandesBR
approved these changes
Nov 6, 2023
|
#436 solves the same thing. We should be careful with merging conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
Since the introduction of
Rocket.drawand the change ofRocket.cp_positionas a Mach dependent function were done in parallel (both merged with only one day difference, without proper rebasing or merging the develop branch before approval), a specific part of the code introduced in #419 was not up to date with the changes made in #377.This made it so a bug was created where
Rocket.drawfailed.New behavior
The bug was fixed.
Breaking change