Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Maintaing Extrapolation when Adding Discrete Functions with Constants #432

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

MateusStano
Copy link
Member

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally

Current behavior & New behavior

When adding a constant value to a discrete Function, the extrapolation method is not maintained. This PR fixes this issue

@Gui-FernandesBR Gui-FernandesBR added the Bug Something isn't working label Oct 8, 2023
@Gui-FernandesBR
Copy link
Member

Well done, @MateusStano !

Did you also conder other occurrencies of the same behavior in the same class?
Please try to taka a look at the following code lines too: 1720* ,1722, 1743, 1746, 1789, 1851, 1869, 2039*, 2054, 2329.

  • Specially the 1720 and 2039, I think they are the most important ones.

@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.0.0 milestone Oct 9, 2023
@Gui-FernandesBR Gui-FernandesBR merged commit 3f9271e into develop Oct 9, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the bug/function-add-extrapolation-keep branch October 14, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants