BUG: env analysis altitudes ASL mistake (solve #371) #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Gui-FernandesBR
added
Bug
phmbressan
approved these changes
Sep 6, 2023
|
Good PR, fixes up nomenclature confusion. As a side note for a seperate docs PR, the functions regarding geopotential calculation and parameters bilinear interpolation would benefit a lot from a update in their docstrings. |
@phmbressan thks for fast reviewing. Regarding the documentation... Are we looking to the same versions?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Code base maintenance (refactoring, formatting, renaming):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
It says AGL, but it is actually ASL.
What is the new behavior?
Environment Analysis no longer suffers from ASL/AGL label mistakes
Does this introduce a breaking change?
Other information
It only changes the labels of some charts. Numerical results are kept the same