Dockerizes app and removes unused data #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gui-FernandesBR
previously approved these changes
Dec 16, 2023
luimot
reviewed
Dec 20, 2023
| jsonpickle | ||
| gunicorn | ||
| uvicorn | ||
| urllib3<2 |
There was a problem hiding this comment.
Was that issue with urllib version resolved? Docker & the local python 3.11 works but would like to confirm still
There was a problem hiding this comment.
Yep, with docker we don't need to worry about this anymore
luimot
reviewed
Dec 20, 2023
There was a problem hiding this comment.
Spotted a "RocketPY" under "Simulating and extracting RocketPY native class" other than that @Gui-FernandesBR 's recommendation was great
There was a problem hiding this comment.
I will make sure to update the README and web docs accordingly in the next PR when I split the routes
luimot
previously requested changes
Dec 20, 2023
luimot
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.