[NEW] Header Redesign #7750
Merged
[NEW] Header Redesign #7750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
work in progress
work in progress
karlprieb
previously requested changes
Aug 15, 2017
| height: 77px; | ||
| padding: 20px; | ||
|
|
||
| color: var(--color-dark); |
There was a problem hiding this comment.
Why didn't you create a variable for this?
|
|
||
| &__toggle-favorite { | ||
| color: var(--header-toggle-favorite-star-color); | ||
| &.--empty { |
There was a problem hiding this comment.
I think this cl;ass don't exist.
| @@ -50,6 +50,14 @@ const openProfileTabOrOpenDM = (e, instance, username) => { | |||
| }; | |||
|
|
|||
| Template.room.helpers({ | |||
| avatarUrl() { | |||
There was a problem hiding this comment.
You're returning an avatar background and not the avatar url, change the name or return only the url :)
and fix some flexs
skipping due some features that need fixing
[NEW] Smaller accountBox
[NEW] Sidebar item width to 100%
[NEW] Unify unread and mentions badge
[FIX] remove accountBox from admin menu
Manual push by LingoHub User: Gabriel Engel. Project: Rocket.Chat Made with ❤️ by https://lingohub.com
Manual push by LingoHub User: Gabriel Engel. Project: Rocket.Chat Made with ❤️ by https://lingohub.com
Sync translations from LingoHub
Update Meteor to 1.5.2.2
[FIX] Various LDAP issues & Missing pagination
Manual push by LingoHub User: Rodrigo Nascimento. Project: Rocket.Chat Made with ❤️ by https://lingohub.com
Manual push by LingoHub User: Rodrigo Nascimento. Project: Rocket.Chat Made with ❤️ by https://lingohub.com
LingoHub based on develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Parts done so far:
More Screenshots...
closes #7776
closes #7772
closes #8075