Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Prevent Ctrl key on message field from reloading messages list #7033

Merged
merged 2 commits into from
May 24, 2017

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 19, 2017

ctrl on message textarea was reloading message.
I fixed the test, but commented the if because the method doesnt work(@sampaiodiego )
@RocketChat/core

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7033 May 19, 2017 14:49 Inactive
@ggazzo ggazzo changed the title [FIX] ctrl message reload message [FIX] ctrl on message textarea reload message list May 19, 2017
@ggazzo ggazzo changed the title [FIX] ctrl on message textarea reload message list [FIX] ctrl on textarea message reload message list May 19, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7033 May 19, 2017 15:46 Inactive
@sampaiodiego sampaiodiego changed the title [FIX] ctrl on textarea message reload message list [FIX] Prevent Ctrl key on message field from reloading messages list May 23, 2017
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug was introduced by a conversion and is really annoing.

@engelgabriel engelgabriel merged commit caeea79 into develop May 24, 2017
@engelgabriel engelgabriel deleted the fix-ctrl-message branch May 24, 2017 12:24
@engelgabriel
Copy link
Member

@ggazzo can you create an issue with the TODO you've added to the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants