Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] LDAP: Use variables in User_Data_FieldMap for name mapping #6921

Merged
merged 4 commits into from
May 17, 2017

Conversation

bbrauns
Copy link
Contributor

@bbrauns bbrauns commented May 9, 2017

@RocketChat/core

This refers to #6172. A lot of ldap backends do not have a single attribut with the users name, but rather a combination of multiple. This PR makes it possible to use variables in the ldap userdata mapping as seen in the screenshot below. The variables will be replaced with the actual ldap values on ldap user sync.

fieldmap

@engelgabriel engelgabriel requested a review from rodrigok May 9, 2017 21:33
@engelgabriel engelgabriel added this to the 0.57.0 milestone May 9, 2017
@rodrigok
Copy link
Member

@bbrauns Awesome addition, thanks.

Can you open another PR improving the message bellow the field to explain this new option?

Thanks

@rodrigok rodrigok merged commit 81a7729 into RocketChat:develop May 17, 2017
@bbrauns
Copy link
Contributor Author

bbrauns commented May 17, 2017

I will do so. Thx for merging 😃

@bbrauns bbrauns deleted the feature/ldap_field_map branch May 17, 2017 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants