Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Incorrect error message when creating channel #6747

Conversation

gdelavald
Copy link
Contributor

@RocketChat/core

Closes #6711

The validation method wasn't being able to find the actual label for the inputs since it was changed from 'label' to 'span' in the html in a previous commit. So I rolled back the label versions since, in my opinion, it makes more sense than having the 'span's there. Changed the css selector as well and removed some console logging.

Message when trying to create a channel with empty name:
correct error message

@rodrigok rodrigok merged commit 1ced54e into RocketChat:develop Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants