Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert markdown to js #6694

Merged
merged 2 commits into from
Apr 18, 2017
Merged

Convert markdown to js #6694

merged 2 commits into from
Apr 18, 2017

Conversation

ehkasper
Copy link
Contributor

@ehkasper ehkasper commented Apr 14, 2017

@RocketChat/core

hey folks, I'm trying to transpile coffee to JS in markdown.

Was getting the following error in the markdowncode.js file:
TypeError: Cannot call a class as a function. This usually means the function is being called w/o the new keyword. As the class is being passed in some sort of callback, I suppose it's called as a function, so I created a new function there to adapt in those cases.

CI is failing due to Jasmine methods not being declared as global. Should I add it to eslintrc?

@CLAassistant
Copy link

CLAassistant commented Apr 14, 2017

CLA assistant check
All committers have signed the CLA.

@@ -0,0 +1,5 @@
describe('rocketchat:markdown Client', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the near future we will replace this with proper unit tests using mocha, so this file can be removed for now.

@rodrigok rodrigok merged commit bb173ea into RocketChat:develop Apr 18, 2017
@rodrigok
Copy link
Member

@ehkasper Thanks for this contribution 😄

@ehkasper ehkasper deleted the markdown-coffee branch April 19, 2017 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants