Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: Room announcement #6351

Merged
merged 9 commits into from
Mar 29, 2017
Merged

New feature: Room announcement #6351

merged 9 commits into from
Mar 29, 2017

Conversation

billtt
Copy link
Contributor

@billtt billtt commented Mar 13, 2017

@RocketChat/core

Users that have room editing privileges can set announcement for the room. Announcements will show on top of the room, just below the room name. Please see the attachment for how the announcement looks like.

image

the message in the screenshot "Room topic changed to ..." has been fixed in latest commit (should be "Room announcement changed to...")

@Nemra1
Copy link

Nemra1 commented Mar 13, 2017

+1
i love it

@engelgabriel engelgabriel modified the milestone: Google Cloud Next 17 Mar 20, 2017
Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anyway to make the announcement go away until it changes again? Or is it meant to always be there?

@@ -22,6 +22,11 @@
<span class="room-topic">{{{RocketChatMarkdown roomTopic}}}</span>
</h2>
</header>
{{#if showAnnouncement}}
<div class="fixed-title announcement">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix this spacing and indentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed @graywolf336

@billtt
Copy link
Contributor Author

billtt commented Mar 21, 2017

@graywolf336 In our team it is required to always be there. Otherwise a simply @ALL would suffice. But I'll see if it's better to have the option to hide it when it's in use.

Copy link
Member

@rodrigok rodrigok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some way to dismiss the announcement, if it should be fixed you should use topic for that.

But for now is better than nothing 😄 we can improve it later

@engelgabriel engelgabriel added this to the 0.55.0 milestone Mar 29, 2017
@engelgabriel engelgabriel merged commit 926dd8e into RocketChat:develop Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants