Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Channel Name Not Displayed in Leave Confirmation Dialog #35290

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Ansh-dS
Copy link

@Ansh-dS Ansh-dS commented Feb 21, 2025

Proposed changes (including videos or screenshots)

The %s placeholder is getting replaced with the actual group/channel name in the warning message.

Screen.Recording.2025-02-21.123100.mp4

Issue(s)

#35289

Steps to test or reproduce

  1. Create a Group, Channel, or Team.
  2. Locate the newly created group/channel in the left pane under Omnichannel.
  3. Click on the three-dot menu next to the group/channel.
  4. Select "Leave" from the dropdown.

@Ansh-dS Ansh-dS requested a review from a team as a code owner February 21, 2025 07:48
Copy link
Contributor

dionisio-bot bot commented Feb 21, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ansh-dS seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Ansh-dS Ansh-dS changed the title Channel Name Not Displayed in Leave Confirmation Dialog Bug: Channel Name Not Displayed in Leave Confirmation Dialog Feb 21, 2025
@Ansh-dS Ansh-dS changed the title Bug: Channel Name Not Displayed in Leave Confirmation Dialog Fix: Channel Name Not Displayed in Leave Confirmation Dialog Feb 21, 2025
@Ansh-dS Ansh-dS changed the title Fix: Channel Name Not Displayed in Leave Confirmation Dialog fix: Channel Name Not Displayed in Leave Confirmation Dialog Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants