Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retention policy settings migration not running #34935

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jan 10, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-924

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 10, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: b17a66b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 10, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34935/

Built to branch gh-pages at 2025-01-20 14:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (cb5695b) to head (b17a66b).
Report is 1 commits behind head on release-7.3.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.3.0   #34935      +/-   ##
=================================================
- Coverage          59.17%   59.17%   -0.01%     
=================================================
  Files               2821     2819       -2     
  Lines              68140    67715     -425     
  Branches           15155    15081      -74     
=================================================
- Hits               40325    40073     -252     
+ Misses             24981    24820     -161     
+ Partials            2834     2822      -12     
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh added this to the 7.3.0 milestone Jan 10, 2025
@gabriellsh gabriellsh marked this pull request as ready for review January 10, 2025 20:59
@gabriellsh gabriellsh requested a review from a team as a code owner January 10, 2025 20:59
KevLehman
KevLehman previously approved these changes Jan 10, 2025
ggazzo
ggazzo previously requested changes Jan 13, 2025
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bring back the softmigration and wait for the next major release to remove run the migration properly

@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jan 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 20, 2025
@gabriellsh gabriellsh changed the base branch from develop to release-7.3.0 January 20, 2025 14:31
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a changeset, don't we?

@kodiakhq kodiakhq bot merged commit 6bddcc9 into release-7.3.0 Jan 20, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/retentionMigration branch January 20, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants