Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace useMutableCallback #34902

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 7, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 2d176ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.14%. Comparing base (bfa92f4) to head (2d176ea).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34902      +/-   ##
===========================================
- Coverage    59.18%   59.14%   -0.04%     
===========================================
  Files         2821     2821              
  Lines        68141    67981     -160     
  Branches     15154    15148       -6     
===========================================
- Hits         40327    40208     -119     
+ Misses       24979    24938      -41     
  Partials      2835     2835              
Flag Coverage Δ
unit 74.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34902/
on branch gh-pages at 2025-01-07 20:11 UTC

@tassoevan tassoevan marked this pull request as ready for review January 7, 2025 22:09
@tassoevan tassoevan requested review from a team as code owners January 7, 2025 22:09
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tassoevan tassoevan merged commit 7839bf0 into develop Jan 8, 2025
49 checks passed
@tassoevan tassoevan deleted the refactor/use-effect-event branch January 8, 2025 03:46
@ggazzo ggazzo added this to the 7.3.0 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants