-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Invalid values as React nodes #34901
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34901 +/- ##
===========================================
- Coverage 59.13% 59.12% -0.01%
===========================================
Files 2819 2819
Lines 67957 67939 -18
Branches 15138 15134 -4
===========================================
- Hits 40188 40172 -16
+ Misses 24935 24934 -1
+ Partials 2834 2833 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
6586d0b
to
d56087d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
God bless u
0beaeb5
to
2716e0f
Compare
Proposed changes (including videos or screenshots)
It fixes types for values that ended up in JSX as React nodes.
Issue(s)
Steps to test or reproduce
Further comments
The types from
@types/react@17.*
are too lenient, but the next majors are tighter. Therefore this is preparation for upgrade.