Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Invalid values as React nodes #34901

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It fixes types for values that ended up in JSX as React nodes.

Issue(s)

Steps to test or reproduce

Further comments

The types from @types/react@17.* are too lenient, but the next majors are tighter. Therefore this is preparation for upgrade.

Copy link
Contributor

dionisio-bot bot commented Jan 7, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 2716e0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR Preview Action v1.5.0
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34901/
on branch gh-pages at 2025-01-09 18:16 UTC

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.12%. Comparing base (4aa95b6) to head (2716e0f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34901      +/-   ##
===========================================
- Coverage    59.13%   59.12%   -0.01%     
===========================================
  Files         2819     2819              
  Lines        67957    67939      -18     
  Branches     15138    15134       -4     
===========================================
- Hits         40188    40172      -16     
+ Misses       24935    24934       -1     
+ Partials      2834     2833       -1     
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review January 7, 2025 19:58
@tassoevan tassoevan requested review from a team as code owners January 7, 2025 19:58
@tassoevan tassoevan force-pushed the refactor/react-node branch from 6586d0b to d56087d Compare January 8, 2025 03:47
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God bless u

@tassoevan tassoevan force-pushed the refactor/react-node branch from 0beaeb5 to 2716e0f Compare January 9, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants