-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Input fields in userPreferences/idleTimeLimit option. #34899
base: develop
Are you sure you want to change the base?
feat: Add Input fields in userPreferences/idleTimeLimit option. #34899
Conversation
…iyush-303/Rocket.Chat into addingFeatureInUserPresence
…iyush-303/Rocket.Chat into addingFeatureInUserPresence
…iyush-303/Rocket.Chat into addingFeatureInUserPresence
…iyush-303/Rocket.Chat into addingFeatureInUserPresence
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: a789d81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d7197fe
to
b653d23
Compare
hey, there are linting errors |
fixed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34899 +/- ##
========================================
Coverage 59.22% 59.22%
========================================
Files 2824 2824
Lines 68072 68072
Branches 15153 15153
========================================
Hits 40316 40316
Misses 24924 24924
Partials 2832 2832
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hey @Gustrb, Could you please review this? I've also added a video for your reference. |
Also, Please let me know how I can resolve these checks. |
Proposed changes (including videos or screenshots)
After:
![image](https://private-user-images.githubusercontent.com/157290995/400746993-f1cfa2a4-c6b7-43f8-b9fd-443c132aa448.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODA3MTYsIm5iZiI6MTczOTE4MDQxNiwicGF0aCI6Ii8xNTcyOTA5OTUvNDAwNzQ2OTkzLWYxY2ZhMmE0LWM2YjctNDNmOC1iOWZkLTQ0M2MxMzJhYTQ0OC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQwOTQwMTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNWYwOGI2ZDM3OWM5ZWI3NzIzNTk3N2VhMDIyNTBmMjI0OGQzNTdkNWE4ZjU0MzYyMzliM2I3NTgzNjc0MzQ0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.iIE22kV7CWUzAL7iihF0n7rm2ICVNpfTHgkC2GGFcu8)
![image](https://private-user-images.githubusercontent.com/157290995/400747128-eecd0dfb-e08f-4c0d-8e25-d5a11702b5bd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODA3MTYsIm5iZiI6MTczOTE4MDQxNiwicGF0aCI6Ii8xNTcyOTA5OTUvNDAwNzQ3MTI4LWVlY2QwZGZiLWUwOGYtNGMwZC04ZTI1LWQ1YTExNzAyYjViZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQwOTQwMTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05YTRiYTc0OGFlM2VlZDZlNDU1NTRlZDcwNjQ4NWMwOTdlMDMwN2FjOTcyM2E2NzVhMTM5NDk5MzU3M2I0MmVjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.P8wd5_IPJIaguXSu9mVyH2aTrRxq-CS45HHCxacRwiw)
Before:
Issue(s)
closes #33566
Steps to test or reproduce
Further comments
Gustrb I followed the same way of solution you were talking about in #33708
Screencast.from.2025-02-03.19-03-40.webm