Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: system throws GUI Application error while enabling, disabling and uninstalling an app. #34887

Merged

Conversation

Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Jan 6, 2025

Proposed changes (including videos or screenshots)

Whenever an app gets uninstalled, marketplace removes its internal data so subsequent calls to get its requests returns null, that would, upon rerender, cause an error, since we would be filtering a null object.
To fix it, I am just adding a fallback.

Issue(s)

Steps to test or reproduce

  • Go to marketplace
  • Click on install app
  • Once app is installed, click request tab
  • Click 3 dots to disable an app or click 3 dots to uninstall an app.

Expected Result:
System should disable, enable or uninstall app as requested by user.

Actual Result:
System throws GUI application error.

Further comments

CONN-459

Copy link
Contributor

dionisio-bot bot commented Jan 6, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: 0b70df2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 6, 2025

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34887/
on branch gh-pages at 2025-01-07 16:25 UTC

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.18%. Comparing base (86567ca) to head (cf15b9b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #34887    +/-   ##
=========================================
  Coverage    59.18%   59.18%            
=========================================
  Files         2821     2821            
  Lines        68141    67592   -549     
  Branches     15154    15044   -110     
=========================================
- Hits         40327    40007   -320     
+ Misses       24979    24771   -208     
+ Partials      2835     2814    -21     
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb marked this pull request as ready for review January 6, 2025 16:18
@Gustrb Gustrb requested review from a team as code owners January 6, 2025 16:18
@Gustrb Gustrb requested review from tassoevan and rique223 January 6, 2025 17:02
rique223
rique223 previously approved these changes Jan 6, 2025
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Jan 7, 2025
@tassoevan tassoevan added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Jan 7, 2025
@dionisio-bot dionisio-bot bot removed the stat: QA assured Means it has been tested and approved by a company insider label Jan 7, 2025
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jan 7, 2025
@Gustrb Gustrb added this to the 7.3.0 milestone Jan 7, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 7, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 7, 2025
@Gustrb Gustrb added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Jan 7, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 7, 2025
@kodiakhq kodiakhq bot merged commit bfa92f4 into develop Jan 7, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the fix/gui-crash-on-disabling-apps-while-on-request-tab branch January 7, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants