-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: system throws GUI Application error while enabling, disabling and uninstalling an app. #34887
fix: system throws GUI Application error while enabling, disabling and uninstalling an app. #34887
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 0b70df2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34887 +/- ##
=========================================
Coverage 59.18% 59.18%
=========================================
Files 2821 2821
Lines 68141 67592 -549
Branches 15154 15044 -110
=========================================
- Hits 40327 40007 -320
+ Misses 24979 24771 -208
+ Partials 2835 2814 -21
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Whenever an app gets uninstalled, marketplace removes its internal data so subsequent calls to get its requests returns null, that would, upon rerender, cause an error, since we would be filtering a null object.
To fix it, I am just adding a fallback.
Issue(s)
Steps to test or reproduce
Expected Result:
System should disable, enable or uninstall app as requested by user.
Actual Result:
System throws GUI application error.
Further comments
CONN-459