Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor new room sound #34207

Merged
merged 4 commits into from
Dec 19, 2024
Merged

chore: refactor new room sound #34207

merged 4 commits into from
Dec 19, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Dec 17, 2024 •
edited
Loading

found during this issue:
rocketchat.atlassian.net/browse/CORE-811

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 17, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: db13a34

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34207/
on branch gh-pages at 2024-12-18 18:49 UTC

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (037e692) to head (db13a34).
Report is 9 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34207   +/-   ##
========================================
  Coverage    75.81%   75.81%           
========================================
  Files          512      512           
  Lines        22205    22208    +3     
  Branches      5403     5404    +1     
========================================
+ Hits         16834    16837    +3     
  Misses        4720     4720           
  Partials       651      651
Flag Coverage Δ
unit 75.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 7.2.0 milestone Dec 17, 2024
@ggazzo ggazzo marked this pull request as ready for review December 17, 2024 21:23
@ggazzo ggazzo requested a review from a team as a code owner December 17, 2024 21:23
aleksandernsilva
aleksandernsilva requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@aleksandernsilva aleksandernsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the current PR title, changing it to refactor: new room sound might be a better fit.

apps/meteor/client/providers/OmnichannelProvider.tsx
Comment on lines +153 to +167
useEffect(() => {
const observer = LivechatInquiry.find(
{ status: LivechatInquiryStatus.QUEUED },
{
sort: getOmniChatSortQuery(omnichannelSortingMechanism),
limit: omnichannelPoolMaxIncoming,
},
).observe({
added: (_inquiry) => {
KonchatNotification.newRoom();
},
});

return () => observer.stop();
}, [omnichannelPoolMaxIncoming, omnichannelSortingMechanism]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be moved to the queueManager ? Might be worth it taking a look.

apps/meteor/client/hooks/useNotifyUser.ts Show resolved Hide resolved
apps/meteor/client/hooks/useOmnichannelContinuousSoundNotification.ts Outdated Show resolved Hide resolved
@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Dec 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 19, 2024
@ggazzo ggazzo merged commit 48b4cfe into develop Dec 19, 2024
51 checks passed
@ggazzo ggazzo deleted the chore/refactor-session-plim branch December 19, 2024 13:25
MartinSchoeler pushed a commit that referenced this pull request Dec 30, 2024
@ggazzo @MartinSchoeler
chore: refactor new room sound (#34207)
7350679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandernsilva aleksandernsilva aleksandernsilva approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @aleksandernsilva @scuciatto