Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps): runtime orchestration fixes #34205

Merged
merged 9 commits into from
Dec 19, 2024
Merged

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Dec 17, 2024

Proposed changes (including videos or screenshots)

  • Fix wrong stats for total apps failed metric
  • Prevent error being thrown if request to app:getStatus fails
  • Fix getStatus call when app has compiler errors
  • Add pid to metric report from app subprocess
  • Subprocess flag to control metrics report frequency
  • Decrease the timeout for ping requests to 1s
  • Capture failed restart attempts and keep trying
  • Pass spawn id to the subprocess command line to make it more visible

Issue(s)

CONN-445

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 426e293

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/instance-status Patch
@rocket.chat/ui-theming Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps-engine Patch
@rocket.chat/ui-composer Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-voip Patch
@rocket.chat/i18n Patch
@rocket.chat/meteor Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/apps Patch
@rocket.chat/models Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
@rocket.chat/mock-providers Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/network-broker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@d-gubert d-gubert added this to the 7.2.0 milestone Dec 17, 2024
Copy link
Contributor

github-actions bot commented Dec 17, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34205/
on branch gh-pages at 2024-12-19 20:30 UTC

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (ed02a33) to head (426e293).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34205   +/-   ##
========================================
  Coverage    75.81%   75.81%           
========================================
  Files          512      512           
  Lines        22208    22208           
  Branches      5404     5404           
========================================
  Hits         16837    16837           
  Misses        4720     4720           
  Partials       651      651           
Flag Coverage Δ
unit 75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review December 17, 2024 22:44
@d-gubert d-gubert requested a review from a team as a code owner December 17, 2024 22:44
@d-gubert d-gubert marked this pull request as draft December 17, 2024 23:04
@d-gubert d-gubert force-pushed the chore/fix-wrong-app-metric branch from 6bd2b76 to 2054309 Compare December 18, 2024 16:42
@d-gubert d-gubert changed the title fix: wrong metric on app stats and error collecting fix(apps): runtime orchestration fixes Dec 19, 2024
@d-gubert d-gubert force-pushed the chore/fix-wrong-app-metric branch from 140de45 to 2580e4e Compare December 19, 2024 20:22
@d-gubert d-gubert marked this pull request as ready for review December 19, 2024 20:37
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Dec 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 19, 2024
@kodiakhq kodiakhq bot merged commit 76f6239 into develop Dec 19, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the chore/fix-wrong-app-metric branch December 19, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants