fix: stop calling useNotifyUser multiple times #34174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 8169270 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34174 +/- ##
========================================
Coverage 75.79% 75.79%
========================================
Files 511 511
Lines 22132 22132
Branches 5394 5394
========================================
Hits 16775 16775
Misses 4709 4709
Partials 648 648
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
changed the title
MarcosSpessatto
previously approved these changes
Dec 16, 2024
ggazzo
previously approved these changes
Dec 16, 2024
ggazzo
approved these changes
Dec 17, 2024
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
ggazzo
changed the title
|
/patch |
dionisio-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
Co-authored-by: Tasso <tasso.evangelista@rocket.chat> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
|
Pull request #34219 added to Project: "Patch 7.1.1" |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Every time the client loses connection causing the websocket to reconnect and log in again, it was causing the registering multiple callbacks for new notifications.. after a few reconnections there was a lot of callbacks being called and that was causing
KonchatNotification.showDesktopto also be called multiple times, causing probably notifications to being show.Issue(s)
introduced by #33981
CORE-859
Steps to test or reproduce
Further comments