Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apps-engine subprocess handling #34111

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Dec 4, 2024

Proposed changes (including videos or screenshots)

Backport of changes to increase stability of subprocesses under load. Changes have been made on the Core monorepo but need to be published via the old Apps-Engine repo as this version of Rocket.Chat did not include it.

Apps-Engine branch ref: https://github.com/RocketChat/Rocket.Chat.Apps-engine/commits/release/1.43.3-candidate

Original PRs:

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 4, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.10.8, but it targets 6.10.7

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 8a464fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@d-gubert d-gubert added this to the 6.10.8 milestone Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.58%. Comparing base (5d55180) to head (8a464fb).
Report is 1 commits behind head on release-6.10.8.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.8   #34111      +/-   ##
==================================================
- Coverage           56.66%   56.58%   -0.08%     
==================================================
  Files                2505     2504       -1     
  Lines               55683    55706      +23     
  Branches            11518    11529      +11     
==================================================
- Hits                31550    31523      -27     
- Misses              21474    21516      +42     
- Partials             2659     2667       +8     
Flag Coverage Δ
e2e 56.44% <ø> (-0.10%) ⬇️
unit 71.25% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review December 5, 2024 17:12
@d-gubert d-gubert requested review from a team as code owners December 5, 2024 17:12
@d-gubert d-gubert marked this pull request as draft December 5, 2024 17:14
@d-gubert d-gubert marked this pull request as ready for review December 5, 2024 19:46
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Dec 5, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 5, 2024
@ggazzo ggazzo merged commit 2e9b5ff into release-6.10.8 Dec 5, 2024
50 checks passed
@ggazzo ggazzo deleted the patch/apps-engine-fixes branch December 5, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants